FIO-9059: fixed an issue where the string type returns for textarea with json type #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
brendanbond
requested changes
Sep 26, 2024
src/utils/formUtil.ts
Outdated
| @@ -193,6 +193,12 @@ export function getModelType(component: Component): keyof typeof MODEL_TYPES_OF_ | |||
| return component.modelType; | |||
| } | |||
|
|
|||
| switch (component.type) { | |||
There was a problem hiding this comment.
I think I'd rather just treat textarea components like selects and make their data model just 'any' to begin with. Also, see my comment in the upstream formio.js PR
There was a problem hiding this comment.
I have changed the textarea data model to 'any' and added normalization logic for it in the renderer.
I also added a fix for the issue where the validation error appears for multiple textarea with JSON type when the first value is array.
…s when textarea has array as a first value
brendanbond
approved these changes
Sep 27, 2024
brendanbond
deleted the
FIO-9059-fixed-incorrect-type-for-tetarea-json
branch
lane-formio
pushed a commit
that referenced
this pull request
Sep 30, 2024
…-tetarea-json FIO-9059: fixed an issue where the string type returns for textarea with json type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9059
Description
What changed?
Added a check that returns any type for textarea that is configured to save as JSON
Dependencies
formio/formio.js#5829
How has this PR been tested?
tests
Checklist: