fix: request count race condition #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-bleyl-form3
force-pushed
the
jonas-fix-request-count
branch
from
fcbc8b5
to
e64ec7c
Compare
jonas-bleyl-form3
force-pushed
the
jonas-fix-request-count
branch
from
e64ec7c
to
bc6cf15
Compare
sofib-form3
reviewed
Dec 23, 2022
|
@sofib-form3 Done. The test fails without the fix as expected. I did have to make a change to the concurrent requests tests as they weren't actually running the requests concurrently. |
sofib-form3
reviewed
Dec 23, 2022
| for _, res := range s.userResponses { | ||
| s.assert.Equal(res.StatusCode, s.modifiedNameStatusCode, "expected user status code") | ||
| for i, res := range s.userResponses { | ||
| if s.modifiedNameAttempt == nil || *s.modifiedNameAttempt == i+1 { |
There was a problem hiding this comment.
Modifying attempt and number of concurrent requests have different results here - runs are concurrent so it may be out of order, perhaps the test would be more valuable if window of opportunity to fail was greater like using another fixture in test for example 10 requests per second and modify on attempt 4, or 7.
you'd need to figure a way to identify request with response in another way though
|
closed as duplicate of #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling simultaneous requests that affect the same interaction we get a race condition for the request count when applying any modifiers. This is because we increment and retrieve the request count for an interaction in different steps without a lock.
This PR fixes this issue by not relying on the request count that could have been modified by another request.