Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article CSV: fix #47 and #46 #84

Conversation

twothreenine
Copy link
Contributor

TO DO:
#83, #81 (more important)
#80, #82 (less important)
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)

@coveralls
Copy link

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10108625566

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 104 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-1.2%) to 43.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/lib/foodsoft_file.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
app/helpers/articles_helper.rb 2 55.56%
lib/article_units_lib.rb 4 57.43%
app/models/article_version.rb 6 73.56%
app/models/article_category.rb 6 50.0%
app/models/article.rb 9 45.95%
app/lib/spreadsheet_file.rb 11 21.43%
app/lib/foodsoft_file.rb 15 15.79%
app/models/supplier.rb 22 40.82%
app/controllers/articles_controller.rb 29 26.58%
Totals Coverage Status
Change from base Build 10108552298: -1.2%
Covered Lines: 2974
Relevant Lines: 6869

💛 - Coveralls

@twothreenine twothreenine force-pushed the On-#47-Improve-understandability-of-article-upload/download-spreadsheet branch 2 times, most recently from 225d453 to 2461a55 Compare July 24, 2024 08:50
@lentschi lentschi force-pushed the On-#47-Improve-understandability-of-article-upload/download-spreadsheet branch from 2461a55 to 4b2098b Compare July 26, 2024 09:00
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
@lentschi lentschi force-pushed the On-#47-Improve-understandability-of-article-upload/download-spreadsheet branch from 4b2098b to faa1870 Compare July 26, 2024 13:27
@lentschi lentschi merged commit 3be31d5 into master Jul 26, 2024
2 of 4 checks passed
lentschi pushed a commit that referenced this pull request Oct 11, 2024
- rearrange CSV columns as I suggested in #47
- add locales for column headings according to my suggestions in #50 (to do: adjust terms across menus -- post-merge?)
- update documentation of CSV layout (#46)

TO DO:
any adaptations for rearranged tables necessary which I've overlooked? (for example sync feature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants