Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si convertability #70

Merged
merged 4 commits into from
Jun 28, 2024
Merged

On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si convertability #70

merged 4 commits into from
Jun 28, 2024

Conversation

lentschi
Copy link
Contributor

Make display of decimals dependant on supplier_order_unit's si convertability

@lentschi lentschi mentioned this pull request May 24, 2024
Closed
@coveralls
Copy link

coveralls commented May 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9714324956

Details

  • 11 of 51 (21.57%) changed or added relevant lines in 4 files are covered.
  • 142 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+1.8%) to 45.129%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/helpers/orders_helper.rb 3 6 50.0%
app/documents/order_fax.rb 2 18 11.11%
app/lib/order_txt.rb 5 26 19.23%
Files with Coverage Reduction New Missed Lines %
app/models/supplier.rb 1 39.8%
app/lib/order_txt.rb 1 21.95%
app/controllers/application_controller.rb 1 85.42%
app/models/user.rb 1 66.91%
plugins/wiki/app/models/page.rb 1 54.35%
plugins/messages/app/models/message.rb 2 45.78%
app/controllers/home_controller.rb 3 20.83%
app/controllers/concerns/auth.rb 3 59.26%
app/models/task.rb 5 49.23%
app/models/article.rb 5 41.44%
Totals Coverage Status
Change from base Build 9419213915: 1.8%
Covered Lines: 3085
Relevant Lines: 6836
💛 - Coveralls

@twothreenine
Solve #42: Improve fax PDF, CSV, text
f1e16de 
- outsource format_units_to_order to OrderHelper
- fax text: include unit, adjust column width
- fax PDF & text: only include order number if any present
@twothreenine twothreenine force-pushed the bugfix/issue-42-decimals-dependant-on-si-convertability branch from 9b10975 to f1e16de Compare May 27, 2024 18:26
twothreenine
twothreenine reviewed Jun 7, 2024
View reviewed changes
app/lib/order_txt.rb Outdated Show resolved Hide resolved
lentschi
lentschi commented Jun 7, 2024
View reviewed changes
app/lib/order_txt.rb Outdated Show resolved Hide resolved
app/lib/order_txt.rb Outdated Show resolved Hide resolved
app/documents/order_fax.rb Outdated Show resolved Hide resolved
app/documents/order_fax.rb Outdated Show resolved Hide resolved
app/documents/order_fax.rb Outdated Show resolved Hide resolved
app/helpers/orders_helper.rb Outdated Show resolved Hide resolved
app/helpers/orders_helper.rb Outdated Show resolved Hide resolved
@lentschi
On #42:
dad0bb9 
- Adapted order_txt to generalized creating the text table and added
  spec
- Code style fixes for order_fax
@lentschi lentschi force-pushed the bugfix/issue-42-decimals-dependant-on-si-convertability branch from 192c180 to dad0bb9 Compare June 21, 2024 16:00
@lentschi lentschi marked this pull request as ready for review June 22, 2024 07:41
@lentschi lentschi requested a review from twothreenine June 22, 2024 07:41
@twothreenine
Copy link
Contributor

I found an error and posted a solution: dad0bb9#r143648091 (don't know why my comment doesn't show up in this stream)

Otherwise good to go 👍

@lentschi lentschi merged commit c73596b into master Jun 28, 2024
4 checks passed
@lentschi lentschi deleted the bugfix/issue-42-decimals-dependant-on-si-convertability branch June 28, 2024 14:29
lentschi added a commit that referenced this pull request Jul 26, 2024
@lentschi @twothreenine
On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si c…
602cff1 
…onvertability (#70)

* On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si convertability

* Solve #42: Improve fax PDF, CSV, text

- outsource format_units_to_order to OrderHelper
- fax text: include unit, adjust column width
- fax PDF & text: only include order number if any present

* On #42:

- Adapted order_txt to generalized creating the text table and added
  spec
- Code style fixes for order_fax

* On #42 Fixes error dad0bb9#r143648091

---------

Co-authored-by: twothreenine <[email protected]>
lentschi added a commit that referenced this pull request Oct 11, 2024
@lentschi @twothreenine
On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si c…
a228b3e 
…onvertability (#70)

* On #42: Fax pdf/csv: Decimals dependant on supplier_order_unit's si convertability

* Solve #42: Improve fax PDF, CSV, text

- outsource format_units_to_order to OrderHelper
- fax text: include unit, adjust column width
- fax PDF & text: only include order number if any present

* On #42:

- Adapted order_txt to generalized creating the text table and added
  spec
- Code style fixes for order_fax

* On #42 Fixes error dad0bb9#r143648091

---------

Co-authored-by: twothreenine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twothreenine twothreenine Awaiting requested review from twothreenine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lentschi @coveralls @twothreenine