Skip to content

On #21: stock orders: prohibit 'ordering' more than what's on stock #138

On #21: stock orders: prohibit 'ordering' more than what's on stock

On #21: stock orders: prohibit 'ordering' more than what's on stock #138

Triggered via push March 23, 2024 14:38
Status Failure
Total duration 37s
Artifacts

rubocop.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
test: app/controllers/suppliers_controller.rb#L27
Lint/DuplicateMethods: Method `SuppliersController#edit` is defined at both app/controllers/suppliers_controller.rb:23 and app/controllers/suppliers_controller.rb:27.
test: app/lib/bank_account_connector.rb#L101
Naming/AccessorMethodName: Do not prefix writer method names with `set_`.
test: app/lib/bank_account_connector.rb#L113
Naming/AccessorMethodName: Do not prefix writer method names with `set_`.
test: app/lib/bank_transaction_reference.rb#L4
Lint/MixedRegexpCaptureTypes: Do not mix named captures and numbered captures in a Regexp literal.
test: app/lib/financial_transactions_csv.rb#L20
Rails/FindEach: Use `find_each` instead of `each`.
test: app/lib/foodsoft/expansion_variables.rb#L80
Rails/SelectMap: Use `pluck(:name)` instead of `select` with `map`.
test: app/lib/foodsoft_config.rb#L67
Security/YAMLLoad: Prefer using `YAML.safe_load` over `YAML.load`.
test: app/lib/foodsoft_config.rb#L135
Lint/ReturnInVoidContext: Do not return a value in `[]=`.
test: app/lib/foodsoft_config.rb#L143
Lint/SuppressedException: Do not suppress exceptions.
test: app/lib/foodsoft_config.rb#L223
Naming/AccessorMethodName: Do not prefix writer method names with `set_`.
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/