Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3159: Display holdings names in Consortial holdings accordion for user without inventory permissions in member tenants #2699

Merged
merged 5 commits into from
Dec 20, 2024
Merged

UIIN-3159: Display holdings names in Consortial holdings accordion for user without inventory permissions in member tenants #2699

merged 5 commits into from
Dec 20, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Holdings locations in Consortial holdings accordion should be displayed regardless of user permissions and affiliations.

Approach

  • Get location's name from the global context, where are stored all the user's locations.

Refs

UIIN-3159

Screenshots

Before

image

After

image

@OleksandrHladchenko1
UIIN-3159: Display holdings names in Consortial holdings accordion fo…
6ab796d 
…r user without inventory permissions in member tenants
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   15m 37s ⏱️ +20s
1 023 tests ±0  1 021 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 030 runs  ±0  1 028 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 45eee17. ± Comparison against base commit f567735.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 0b447d0 into master Dec 20, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-3159 branch December 20, 2024 13:41
OleksandrHladchenko1 added a commit that referenced this pull request Dec 24, 2024
@OleksandrHladchenko1
UIIN-3159: Display holdings names in Consortial holdings accordion …
acea98f 
…for user without inventory permissions in member tenants (#2699)

* UIIN-3159: Display holdings names in Consortial holdings accordion for user without inventory permissions in member tenants

* UIIN-3159: Fix tests

* UIIN-3159: Fix tests

(cherry picked from commit 0b447d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Awaiting requested review from Dmytro-Melnyshyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @BogdanDenis @mariia-aloshyna