UIIN-2497 Fix exception when closing Fast Add record modal #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BogdanDenis
requested review from
mariia-aloshyna,
Dmytro-Melnyshyn and
a team
| @@ -548,7 +548,7 @@ class InstancesList extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| toggleNewFastAddModal = ({ instanceRecord }) => { | |||
| toggleNewFastAddModal = ({ instanceRecord } = {}) => { | |||
There was a problem hiding this comment.
If I'm not mistaken on line 739 buildOnClickHandler calls this function with arg this.context.sendCallout which is a function, not an object with instanceRecord prop. Looks like something is not correct here
There was a problem hiding this comment.
Nice catch @mariia-aloshyna, I added a separate function to handle closing of the modal. It will always receive the same type of argument
mariia-aloshyna
approved these changes
Nov 13, 2023
|
Update CHANGELOG also please |
This is a follow-up request to this one #2331 |
Terala-Priyanka
requested changes
Nov 14, 2023
Hi @Terala-Priyanka see a comment from Denys above, it's follow-up PR, changelog has been already updated |
|
Kudos, SonarCloud Quality Gate passed! |
Terala-Priyanka
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When closing Fast Add modal, function
toggleNewFastAddModalargument is undefinedIssues
UIIN-2497