Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2630 Updated translations for adding new Instance records. #2343

Merged
merged 1 commit into from
Nov 10, 2023
Merged

UIIN-2630 Updated translations for adding new Instance records. #2343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Inventory search/browse: Do not retain checkbox selections when toggling search segment. Refs UIIN-2477.
* Show Instance record after creating with Fast add option. Refs UIIN-2497.
* Search box/Browse box- Reset all should shift focus back to search box. Refs UIIN-2514.
* Updated translations for adding new Instance records. Refs UIIN-2630.

## [10.0.4] IN PROGRESS

Expand Down
12 changes: 6 additions & 6 deletions src/components/InstancesList/InstancesList.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,12 @@ describe('InstancesList', () => {
});
});

describe('"New Fast Add record" button', () => {
describe('"New fast add record" button', () => {
it('should render', () => {
renderInstancesList({ segment: 'instances' });
openActionMenu();

expect(screen.getByRole('button', { name: 'New Fast Add Record' })).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'New fast add record' })).toBeInTheDocument();
});

describe('when saving the record', () => {
Expand All @@ -369,7 +369,7 @@ describe('InstancesList', () => {
renderInstancesList({ segment: 'instances' });
openActionMenu();

const button = screen.getByRole('button', { name: 'New Fast Add Record' });
const button = screen.getByRole('button', { name: 'New fast add record' });

fireEvent.click(button);
fireEvent.click(screen.getByText('Save & close'));
Expand All @@ -382,20 +382,20 @@ describe('InstancesList', () => {
});
});

describe('"New MARC Bib Record" button', () => {
describe('"New MARC bibliographic record" button', () => {
it('should render', () => {
renderInstancesList({ segment: 'instances' });
openActionMenu();

expect(screen.getByRole('button', { name: 'New MARC Bib Record' })).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'New MARC bibliographic record' })).toBeInTheDocument();
});

it('should redirect to the correct layer', async () => {
jest.spyOn(history, 'push');
renderInstancesList({ segment: 'instances' });
openActionMenu();

const button = screen.getByRole('button', { name: 'New MARC Bib Record' });
const button = screen.getByRole('button', { name: 'New MARC bibliographic record' });

fireEvent.click(button);

Expand Down
4 changes: 2 additions & 2 deletions translations/ui-inventory/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,8 @@
"copyItem": "Duplicate",
"newRequest": "New request",
"fastAdd": "Fast add",
"newMARCRecord": "New MARC Bib Record",
"newFastAddRecord": "New Fast Add Record",
"newMARCRecord": "New MARC bibliographic record",
"newFastAddRecord": "New fast add record",
"newLocalRecord": "New local record",
"newSharedRecord": "New shared record",
"location.confirm.confirmBtn": "Yes",
Expand Down
Loading