Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2514: Search box/Browse box- Reset all should shift focus back to search box #2335

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented Nov 7, 2023

Description

Search box/Browse box- Reset all should shift focus back to search box

Pass refs to <SearchAndSort> and use them to focus search box after reset

Screenshots

chrome_d9penGmUsv.mp4

Issues

UIIN-2514

Related PRs

folio-org/stripes-smart-components#1413
folio-org/stripes-components#2169
folio-org/stripes-acq-components#727

Copy link

github-actions bot commented Nov 7, 2023

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   15m 56s ⏱️ + 2m 27s
903 tests +2  901 ✔️ +2  2 💤 ±0  0 ±0 
908 runs  +2  906 ✔️ +2  2 💤 ±0  0 ±0 

Results for commit 7a120ce. ± Comparison against base commit 6dd0fa8.

♻️ This comment has been updated with latest results.

@@ -6,6 +6,8 @@
* Make Inventory search and browse query boxes expandable. Refs UIIN-2493.
* Added support for `containsAny` match option in Advanced search. Refs UIIN-2486.
* Inventory search/browse: Do not retain checkbox selections when toggling search segment. Refs UIIN-2477.
* Show Instance record after creating with Fast add option. Refs UIIN-2497.
* Search box/Browse box- Reset all should shift focus back to search box. Refs UIIN-2514.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Browse box focused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a PR for Browse
folio-org/stripes-acq-components#727

@mariia-aloshyna
Copy link
Contributor

Fix eslint comments and tests, please

@BogdanDenis
Copy link
Contributor Author

@mariia-aloshyna fixed tests

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@BogdanDenis BogdanDenis merged commit def4aad into master Nov 9, 2023
4 checks passed
@BogdanDenis BogdanDenis deleted the UIIN-2514 branch November 9, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants