UIIN-2590: ECS: Show info message when user in member tenant tries to view shared instance details without permission #2328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If a user is on a member tenant and wants to view details of a shared instance retrieved in an Inventory search, the user must have the central tenant permission: Inventory: Can view instances, holdings, items. Otherwise they see 3 dots. This bugfix replaces the 3 dots with a better indication of the problem.
Approach
InstanceWarningPane
andInstanceLoadingPane
as separate componentsInstanceWarningPane
shows the pure instance pane with a warning banner instead of detailsInstanceLoadingPane
shows the pure instance pane with a loading spinner instead of detailsViewInstanceWrapper
to avoid redundant instance properties checks when the instance is empty yet.centralTenantPermissions
but realized that this request also can be failed, so decided to just check for response error status code.Refs
https://issues.folio.org/browse/UIIN-2590
Screenshots