Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2647: Show only local authorities when share local instance #2327

Merged
merged 8 commits into from
Nov 6, 2023
Merged

UIIN-2647: Show only local authorities when share local instance #2327

merged 8 commits into from
Nov 6, 2023

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented Nov 3, 2023 •
edited
Loading

Purpose

  • Confirmation modal count includes the total local and shared linked fields, instead of just the count of local linked fields.

Approach

  • Added authorities field to fetch authorities by id.
  • Filter local authorities by source.
  • getLinkedAuthorityIds method picks instance's fields which can be linked by MARC Authorities. Then it gets authorities' ids and returns it as flat array of ids in order to create query.
  • Updated unit tests.

Refs

UIIN-2647

Screenshots

UIIN-2647.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  228 suites  ±0   16m 9s ⏱️ + 2m 28s
899 tests ±0  897 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
904 runs  ±0  902 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit b119f95. ± Comparison against base commit 6515018.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 9e781df into master Nov 6, 2023
4 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2647 branch November 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Awaiting requested review from Dmytro-Melnyshyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @BogdanDenis @mariia-aloshyna