UIIN-2493 Make Inventory search and browse query boxes expandable #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BogdanDenis
requested review from
Dmytro-Melnyshyn,
mariia-aloshyna and
a team
This was referenced Oct 26, 2023
OleksandrHladchenko1
approved these changes
Oct 26, 2023
mariia-aloshyna
approved these changes
Oct 26, 2023
| @@ -1178,6 +1178,7 @@ class InstancesList extends React.Component { | |||
| searchableIndexesPlaceholder={null} | |||
| initialResultCount={INITIAL_RESULT_COUNT} | |||
| initiallySelectedRecord={getItem(`${namespace}.${segment}.lastOpenRecord`)} | |||
| inputType="textarea" | |||
There was a problem hiding this comment.
Textarea looks much higher to me
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| ## [10.1.0] IN PROGRESS | |||
|
|
|||
| * Make Inventory search and browse query boxes expandable. Refs UIIN-2493. | |||
There was a problem hiding this comment.
Should the Browse query box be expandable?
There was a problem hiding this comment.
Fixed in folio-org/stripes-acq-components#722
Dmytro-Melnyshyn
approved these changes
Oct 27, 2023
BogdanDenis
force-pushed
the
UIIN-2493
branch
from
e2d6e67 to
04e5a48
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Dmytro-Melnyshyn
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make Inventory search and browse query boxes expandable
Screenshots
chrome_aBXCGEl7SF.mp4
Issues
UIIN-2493
Related PRs
folio-org/stripes-smart-components#1407