Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2628: Optimistic locking message not working for instances in non-consortial tenant #2316

Merged
merged 3 commits into from
Oct 23, 2023
Merged

UIIN-2628: Optimistic locking message not working for instances in non-consortial tenant #2316

merged 3 commits into from
Oct 23, 2023

Conversation

mariia-aloshyna
Copy link
Contributor

@mariia-aloshyna mariia-aloshyna commented Oct 23, 2023 •
edited
Loading

Purpose

Optimistic locking message for an instance in a non-consortial tenant is not displaying properly.

Approach

  • Use mutate func instead of mutateAsync to mutate Instance
  • Fix handling errors during instance mutation

Refs

https://issues.folio.org/browse/UIIN-2628

Screenshots

optimistic-locking-fix.mov

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  226 suites  ±0   13m 33s ⏱️ + 3m 10s
887 tests ±0  885 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
892 runs  ±0  890 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 172f5c3. ± Comparison against base commit f0c4b11.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@mariia-aloshyna mariia-aloshyna merged commit 33589f7 into master Oct 23, 2023
4 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-2628 branch October 23, 2023 14:32
mariia-aloshyna added a commit that referenced this pull request Nov 7, 2023
@mariia-aloshyna
UIIN-2628: Optimistic locking message not working for instances in no…
c52c31d 
…n-consortial tenant (#2316)

(cherry picked from commit 33589f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@OleksandrHladchenko1 OleksandrHladchenko1 Awaiting requested review from OleksandrHladchenko1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariia-aloshyna @BogdanDenis @Dmytro-Melnyshyn