FOLIO-4160: Enable mod-authtoken early (R1-2024) #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianladisch
requested review from
funkymalc,
vkapylou and
eldiiar-duishenaliev
julianladisch
changed the title
DmytrMoroz
force-pushed
the
R1-2024
branch
2 times, most recently
from
85e6745 to
20028e9
Compare
https://folio-org.atlassian.net/browse/FOLIO-4160 Move mod-authtoken to the top of install-extras.json so that it gets installed early. Then it is available when enabling a second module that requires a token to access a permission protected API of a third module. Modules using authtokens don't have the authtoken okapi interface in their requires section of in their module descriptor because they don't use the mod-authtoken HTTP API but the token feature of Okapi. Therefore we need to use the install order to ensure mod-authtoken availability. https://folio-project.slack.com/archives/CFQU1MF61/p1725977004958399?thread_ts=1725933118.184429&cid=CFQU1MF61 mod-authtoken requires mod-permissions and mod-users therefore we use this natural order: 1. mod-permissions 2. mod-users 3. mod-authtoken
julianladisch
force-pushed
the
enable-authtoken-early-R1-2024
branch
from
cc93b67 to
36d1f9b
Compare
julianladisch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/FOLIO-4160
Move mod-authtoken to the top so that it gets installed early.
Then it is available when enabling a second module that requires a token to access a permission protected API of a third module.
Modules using authtokens don't have the authtoken okapi interface in their requires section of in their module descriptor because they don't use the mod-authtoken HTTP API but the token feature of Okapi. Therefore we need to use the install order to ensure mod-authtoken availability.
https://folio-project.slack.com/archives/CFQU1MF61/p1725977004958399?thread_ts=1725933118.184429&cid=CFQU1MF61
mod-authtoken requires mod-permissions and mod-users therefore we use this natural order: