Direct upload to remote s3 #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 4, 2022 17:43
|
Hi @yigitsoy ! Thanks for the PR and sorry for the delay! Did you have time to test this with S3? Adding automated test would not hurt, and I guess the test should just check if the send HTTP requests look correct |
|
Hi @np-8 Thanks for the feedback. I have been using this version to upload to S3 since then. I will try to some tests to make sure that it works in general. |
|
@yigitsoy |
|
Very keen to see this as a feature so giving this a bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address the issue described in #89 where the files can be uploaded to a remote s3 bucket directly without local storage.
@np-8 I tried to keep the changes only on python side. I would be happy if you could see if there are any places that can be improved.