New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java modules #299

Merged

derTobsch merged 6 commits into main from java-modules

Sep 13, 2023

Contributor

derTobsch commented Sep 7, 2023 •

edited

Loading

closes #300

Update readme for needed dependecies
Update readme with module information

derTobsch marked this pull request as draft

September 7, 2023 15:57

derTobsch force-pushed the java-modules branch 2 times, most recently from 95a9a32 to 4210def Compare

September 7, 2023 16:20

derTobsch added this to the 0.20.0 milestone

derTobsch force-pushed the java-modules branch 2 times, most recently from 86c8e9f to f9b3b60 Compare

September 7, 2023 16:34

derTobsch modified the milestones: 0.20.0, General Backlog

derTobsch mentioned this pull request

Add java module info #300

Closed


          Add java modules

735f3da

derTobsch force-pushed the java-modules branch from f9b3b60 to 735f3da Compare

September 8, 2023 14:27

derTobsch marked this pull request as ready for review

September 11, 2023 07:57

derTobsch added this to the 0.20.0 milestone

derTobsch added 5 commits

September 11, 2023 09:59


          Fix scoping

5ea0813


          Only exports the util package to jaxb

14a909b


          Improve readme with more information about dependencies

1afb987


          Improve readme with more information about java module system

9e798e6


          Specifiy opens in module info to not open it fully up...

a3fd4ac

opens de.focus_shift.datasource
because of the instantiation of the ConfigurationService via
reflection

opens de.focus_shift.util;
  because of reflection

opens holidays;
opens descriptions;
because non-class resources cannot be loaded see
https://stackoverflow.com/questions/45166757/loading-classes-and-resources-post-java-9

'A final important difference is that non-class-file resources in a
module are encapsulated by default, and hence cannot be located from
outside the module unless their effective package is open. To load
resources from your own module it’s best to use the resource-lookup
methods in Class or Module, which can locate any resource in your
module, rather than those in ClassLoader, which can only locate
non-class-file resources in the open packages of a module.'

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

derTobsch merged commit 894bd53 into main

11 checks passed

derTobsch deleted the java-modules branch

September 13, 2023 07:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet