Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Virgin Islands (British) public holidays #272

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

XSpielinbox
Copy link
Contributor

🎁 Adds support for the Virgin Islands (British)

However, it is missing translations at the moment, as I did not know how to translate them.

@derTobsch
Copy link
Contributor

Hey @XSpielinbox,

thanks for this pull request and all the other issues. I just went through them all and will give feedback in September. If you want to provide further pull requests of the other issues I would be more than happy.

@derTobsch derTobsch added the type: enhancement A general enhancement label Aug 17, 2023
@XSpielinbox
Copy link
Contributor Author

Hey, @derTobsch ,
I would be more than happy to help with remediation of the other issues, but would need some additional guidance on how to implement it.

I also would be working on adding support for some other countries in the next days. How long do you expect to have this PR open? I would like to base my work on this PR, to avoid merge-conflicts in jollyday-core/src/main/resources/descriptions/holiday_descriptions.properties.

@derTobsch
Copy link
Contributor

Hey, @derTobsch , I would be more than happy to help with remediation of the other issues, but would need some additional guidance on how to implement it.

I also would be working on adding support for some other countries in the next days. How long do you expect to have this PR open? I would like to base my work on this PR, to avoid merge-conflicts in jollyday-core/src/main/resources/descriptions/holiday_descriptions.properties.

Use this branch as your base branch for the other pull requests and so on, because I won't be around for the next two weeks. But in September I will have enough time to release a great version with this enhancements and bug fixes.

Missing translations

Signed-off-by: XSpielinbox <[email protected]>
@derTobsch derTobsch added this to the 0.20.0 milestone Sep 6, 2023
@derTobsch derTobsch merged commit 3e082e1 into focus-shift:main Sep 6, 2023
9 checks passed
@XSpielinbox
Copy link
Contributor Author

Thank you for merging my first merge requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants