Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 defaulted comparisons #1388

Merged
merged 4 commits into from
Jan 30, 2025
Merged

C++20 defaulted comparisons #1388

merged 4 commits into from
Jan 30, 2025

Conversation

trueqbit
Copy link
Collaborator

Use C++20's feature of defaulted comparisons where possible.

Additionally:

  • Runner-up: Qualified all calls to std::remove() with std.
  • Included the C header assert.h instead of the C++ header cassert. This will be important when importing the Standard Library as a named module.

Using named modules the namespace scope will be much stricter, so adhere to it.
`std::any` is only available starting with a C++17 library.
Macros will not be available when importing the Standard Library as a named module. The recommended and only fallback is to include the C header file for `assert()`.
@trueqbit trueqbit requested a review from fnc12 January 29, 2025 18:32
dev/udf_proxy.h Show resolved Hide resolved
dev/udf_proxy.h Show resolved Hide resolved
@trueqbit trueqbit merged commit 493f051 into dev Jan 30, 2025
4 checks passed
@trueqbit trueqbit deleted the upstream/defaulted-comparisons branch January 30, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants