Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for displaying time taken by each player & also Blitz mode Chess #6

Merged
merged 6 commits into from
Jan 20, 2015

Conversation

kiran9k
Copy link
Contributor

@kiran9k kiran9k commented Jan 16, 2015

The time played by each player is being displayed along with the user name . Also , one can set a timeout , inorder to play in Blitz mode (to be specified in chesshub.js file)

@fmbenhassine
Copy link
Owner

Cool! Thank you for this addition 👍

But I think your fork is not up to date with last commits in the master branch.
I have added some comments on outdated code parts. Please make sure to update your branch.

I'll merge your pull request asap.
Thank you for your contribution :-)
Cheers

@@ -1,31 +0,0 @@
# Logs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you undo the deletion of the .gitignore file? may be deleted by error?

@fmbenhassine
Copy link
Owner

A side note, you added handlebars-v2.0.0.js but you didn't imported it in the project.
I'm not sure this is needed since handlebars is already imported:

https://github.com/benas/gamehub.io/blob/master/package.json#L19
https://github.com/benas/gamehub.io/blob/master/app.js#L28

That's all for my review.
Do not hesitate to add your comments.
If it is ok for you, please update the pull request and I'll merge it asap.
Your contribution is welcome!

@kiran9k
Copy link
Contributor Author

kiran9k commented Jan 20, 2015

Hi ,
I just updated the fork to the latest .
I have added codes to display the time played by each player along with the user name . Also , support to Blitz mode chess is also provided .

Cheers

@fmbenhassine
Copy link
Owner

Cool! this goes straight to the master branch :-)

Thank you for your contribution! 👍

Regards
Mahmoud

fmbenhassine pushed a commit that referenced this pull request Jan 20, 2015
Add support for displaying time taken by each player
Add support for Blitz mode
@fmbenhassine fmbenhassine merged commit 3babb88 into fmbenhassine:master Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants