Updates for Flyte docs overhaul #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
3 tasks
added 13 commits
September 5, 2024 16:28
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
…ry captions from tutorials and integrations toctrees Signed-off-by: nikki everett <[email protected]>
…into nikki/docs/refresh
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
added 3 commits
September 30, 2024 12:08
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
3 tasks
neverett
changed the title
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
ppiegaze
previously approved these changes
Oct 3, 2024
cosmicBboy
reviewed
Oct 3, 2024
docs/integrations/index.md
Outdated
| @@ -5,7 +5,7 @@ | |||
| Flyte is designed to be highly extensible and can be customized in multiple ways. | |||
|
|
|||
| ```{note} | |||
| Want to contribute an example? Check out the {doc}`Example Contribution Guide <contribute>`. | |||
| Want to contribute an example? Check out the [Documentation contribution guide](https://docs.flyte.org/en/latest/flytesnacks/contribute.html). | |||
There was a problem hiding this comment.
this will be considered an external link as far as sphinx is concerned, and will always go to the latest version of the docs, regardless of version, can we use a ref or preserve the correct doc directive?
There was a problem hiding this comment.
Good call, I'll use a ref for this, since that doc has been moved to the flyte repo as part of the docs overhaul.
Signed-off-by: nikki everett <[email protected]>
cosmicBboy
approved these changes
Oct 3, 2024
eapolinario
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the flytesnacks component of the Flyte docs overhaul (phase 1). See the related Flyte PR for a full description of this project.
To test these changes, you will need to install the new requirements in
docs-requirements.txt(python -m pip install -r docs-requirements.txt) before building locally.Major changes in this PR