Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing imports to map_task example #1263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing imports to map_task example #1263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3e232
Add missing imports to map_task example
Nov 15, 2023
31f38b7
Merge branch 'master' into update-maptask-example
pingsutw Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/getting_started/optimizing_tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ scale our workload:

```{code-cell} ipython3
import math
from typing import Tuple
from typing import Tuple, List

from flytekit import map_task
from flytekit import map_task, task, workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these have been imported at the beginning for a different example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make each example "self-contained"?

While it's true that previous examples have the import, if a user goes directly to the Map Tasks section, the example won't be complete



@task
Expand Down