This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Skipping of cached task outputs via execution config #489
Merged
hamersaw
merged 6 commits into
flyteorg:master
from
blackshark-ai:cache-eviction-execution-override
Nov 8, 2022
Merged
Skipping of cached task outputs via execution config #489
hamersaw
merged 6 commits into
flyteorg:master
from
blackshark-ai:cache-eviction-execution-override
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorpheusXAUT
changed the title
Skipping of cached task outputs via execution config
Skipping of cached task outputs via execution config #minor
Oct 5, 2022
8 tasks
hamersaw
reviewed
Oct 31, 2022
CatalogClient.Put can now create or update/overwrite artifacts and their data Signed-off-by: Nick Müller <[email protected]>
Updated to latest released versions of flyteidl and flytestdlib Signed-off-by: Nick Müller <[email protected]>
…riting artifact Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
cache-eviction-execution-override
branch
from
November 4, 2022 11:24
b28ee5e
to
a739fa4
Compare
@hamersaw Just pushed an update that renamed the flag from |
…atacatalog client Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
@MorpheusXAUT looks like we need to manually specify the go version for codeql, can you add the middle "step" the
|
hamersaw
changed the title
Skipping of cached task outputs via execution config #minor
Skipping of cached task outputs via execution config
Nov 7, 2022
Signed-off-by: Nick Müller <[email protected]>
@hamersaw Pushed, seems to be working now 👍 |
hamersaw
approved these changes
Nov 8, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Implemented skipping of cached task results via execution config CatalogClient.Put can now create or update/overwrite artifacts and their data Signed-off-by: Nick Müller <[email protected]> * Renamed SkipCache flag to OverwriteCache Updated to latest released versions of flyteidl and flytestdlib Signed-off-by: Nick Müller <[email protected]> * datacatalog client now handles NotFound errors gracefully while overwriting artifact Signed-off-by: Nick Müller <[email protected]> * Refactored updating of artifact data into separate Update method of datacatalog client Signed-off-by: Nick Müller <[email protected]> * Updated to latest released flyteplugins version Signed-off-by: Nick Müller <[email protected]> * Use go 1.18 for CodeQL GHA Signed-off-by: Nick Müller <[email protected]> Signed-off-by: Nick Müller <[email protected]>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Cached output of tasks can now be skipped and overwritten for single executions.
Type
Are all requirements met?
Complete description
flytepropeller now supports the new cache skip flag via execution configuration, causing it to ignore any cached outputs and re-running all tasks. Any stored data will be overwritten with the new results of the execution.
As the HTTP verb PUT can either be used to create or update data, I've decided to extend the
Put
method ofCatalogClient
to allow for either creation or updating of artifacts instead of creating a separate new method.As this uses currently unmerged versions of
flyteidl
,flyteplugins
andflytestdlib
, the PR is created as a draft (for review) until the respective new versions are available.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA