Fix double http in the Spark Driver UI Link

[mucahitkantepe]

Fixes flyteorg/flyte#3623

Spark operator code: https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/5f2efd4ff97e7c0bfdb726a066118d3401576730/pkg/controller/sparkapplication/sparkui.go#L57

This change solves the problem by keeping Flyte compatible with older version of Spark Operator.
Another, simpler implentation is to just pass whatever spark operator gives. Browsers will add https automatically?

[welcome]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[kumare3]

a small code change suggested, then looks good

[codecov]

Codecov Report

Merging #347 (098fa3e) into master (63e1e45) will increase coverage by 1.31%.
The diff coverage is 100.00%.

❗ Current head 098fa3e differs from pull request most recent head 9fb2b0d. Consider uploading reports for the commit 9fb2b0d to get more accurate results

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   62.77%   64.08%   +1.31%     
==========================================
  Files         148      148              
  Lines       12434    10074    -2360     
==========================================
- Hits         7805     6456    -1349     
+ Misses       4034     3023    -1011     
  Partials      595      595              

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
go/tasks/plugins/k8s/spark/spark.go	79.44% <100.00%> (+1.88%)	⬆️

... and 130 files with indirect coverage changes

[hamersaw]

To maintain backwards compatibility does it make sense to check for the prefix rather than removing it (noop if it doesn't exist) and then appending it? Maybe something like

uri := sj.Status.DriverInfo.WebUIIngressAddress
if !strings.HasPrefix("https://") {
    uri = fmt.Sprintf("https://%s", uri)
}
customInfoMap[sparkDriverUI] = uri

[EngHabu]

We shouldn't assume SSL all the time. Does spark enforce ssl?

uri := sj.Status.DriverInfo.WebUIIngressAddress
if !strings.HasPrefix("https://") && !strings.HasPrefix("http://") {
    uri = fmt.Sprintf("https://%s", uri)
}

customInfoMap[sparkDriverUI] = uri

[mucahitkantepe]

I agree, so we should just pass the WebUIIngressAddress value along?

[hamersaw]

@mucahitkantepe yes, and then if it does not contain https or http we can prepend with https as Haytham suggests.

[hamersaw]

work completed in #389