Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ketan Umare <[email protected]>
Signed-off-by: Mücahit Kantepe <[email protected]>
  • Loading branch information
mucahitkantepe and kumare3 authored Apr 27, 2023
1 parent 796e245 commit a069bba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go/tasks/plugins/k8s/spark/spark.go
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,8 @@ func getEventInfoForSpark(sj *sparkOp.SparkApplication) (*pluginsCore.TaskInfo,
}
} else if sj.Status.AppState.State == sparkOp.RunningState && sj.Status.DriverInfo.WebUIIngressAddress != "" {
// Older versions of spark-operator does not have http:// but newer versions have.
customInfoMap[sparkDriverUI] = strings.TrimPrefix(sj.Status.DriverInfo.WebUIIngressAddress, "http://")
customInfoMap[sparkDriverUI] = fmt.Sprintf("https://%s", customInfoMap[sparkDriverUI])
uri := strings.TrimPrefix(sj.Status.DriverInfo.WebUIIngressAddress, "http://")
customInfoMap[sparkDriverUI] = fmt.Sprintf("https://%s", uri)
// Custom doesn't work unless the UI has a custom plugin to parse this, hence add to Logs as well.
taskLogs = append(taskLogs, &core.TaskLog{
Uri: customInfoMap[sparkDriverUI],
Expand Down

0 comments on commit a069bba

Please sign in to comment.