Add codecov exclude_lines configuration #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringohoffman
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
ringohoffman
force-pushed
the
codecov-exclude
branch
from
977dd43 to
da42bfa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
+ Coverage 85.81% 86.13% +0.31%
==========================================
Files 313 313
Lines 23299 23074 -225
Branches 3530 3453 -77
==========================================
- Hits 19995 19874 -121
+ Misses 2701 2611 -90
+ Partials 603 589 -14 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Nov 25, 2023
eapolinario
approved these changes
Nov 27, 2023
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
https://coverage.readthedocs.io/en/latest/config.html#sample-filehttps://coverage.readthedocs.io/en/latest/config.html#sample-file Signed-off-by: Matthew Hoffman <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Configure
exclude_linesfor Codecov. There are certain lines that shouldn't affect code velocity of a PR.See: nedbat/coveragepy#831 (comment)
Apparently this isn't configurable through
codecov.yml🙈 : codecov/codecov-python#107 (comment)Check all the applicable boxes
Related PRs
I opened this because I noticed this issue was affecting an existing PR: #1818 (comment)