Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes docker-image-py dependency #1978

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

thomasjpfan
Copy link
Member

This PR removes the docker-image-py dependency.

Type

  • Housekeeping

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Instead of using docker-image-py, we can use the docker library, to parse the tag.

Tracking Issue

Towards flyteorg/flyte#4418

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c275011) 62.54% compared to head (79873e3) 93.24%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1978       +/-   ##
===========================================
+ Coverage   62.54%   93.24%   +30.70%     
===========================================
  Files         313       88      -225     
  Lines       23249     4188    -19061     
  Branches     3526        0     -3526     
===========================================
- Hits        14540     3905    -10635     
+ Misses       8286      283     -8003     
+ Partials      423        0      -423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docker-image-py is another case of a library that was covering a much larger number of use cases than its counterpart in docker. For our usage though, I have a feeling that docker-image-py is not needed.

@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Nov 20, 2023
@eapolinario eapolinario merged commit 16a4054 into flyteorg:master Nov 20, 2023
73 checks passed
ringohoffman pushed a commit to ringohoffman/flytekit that referenced this pull request Nov 24, 2023
RRap0so pushed a commit to RRap0so/flytekit that referenced this pull request Dec 15, 2023
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants