MAINT Removes pyopenssl dependency #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 62.67% 62.55% -0.13%
==========================================
Files 313 313
Lines 23193 23244 +51
Branches 3514 3524 +10
==========================================
+ Hits 14537 14540 +3
- Misses 8234 8283 +49
+ Partials 422 421 -1 ☔ View full report in Codecov by Sentry. |
thomasjpfan
force-pushed
the
remove_pyopenssl
branch
3 times, most recently
from
6870a8e to
51bba3e
Compare
Signed-off-by: Thomas J. Fan <[email protected]>
eapolinario
reviewed
Nov 17, 2023
Signed-off-by: Thomas J. Fan <[email protected]>
eapolinario
approved these changes
Nov 17, 2023
pingsutw
approved these changes
Nov 17, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* MAINT Removes pyopenssl dependency Signed-off-by: Thomas J. Fan <[email protected]> * MAINT Remove pyopenssl from requirements pip Signed-off-by: Thomas J. Fan <[email protected]> * STY Run linter Signed-off-by: Thomas J. Fan <[email protected]> * CLN Remove unneeded files Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* MAINT Removes pyopenssl dependency Signed-off-by: Thomas J. Fan <[email protected]> * MAINT Remove pyopenssl from requirements pip Signed-off-by: Thomas J. Fan <[email protected]> * STY Run linter Signed-off-by: Thomas J. Fan <[email protected]> * CLN Remove unneeded files Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR removes the dependency on
pyopenssl. According to grpc.ssl_channel_credentials docs it can directly take the PEM-encoded cert as a byte string.Type
Are all requirements met?
Tracking Issue
Towards flyteorg/flyte#4418