Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ArrayNode subNode timeouts #6054

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hamersaw
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (ab04192) to head (f34fb8f).

Files with missing lines Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 52.94% 6 Missing and 2 partials ⚠️
...ler/pkg/apis/flyteworkflow/v1alpha1/node_status.go 0.00% 7 Missing ⚠️
...opeller/pkg/controller/nodes/node_state_manager.go 20.00% 4 Missing ⚠️
...lytepropeller/pkg/controller/nodes/transformers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6054      +/-   ##
==========================================
- Coverage   37.08%   37.08%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132284   132312      +28     
==========================================
+ Hits        49062    49068       +6     
- Misses      78950    78971      +21     
- Partials     4272     4273       +1     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.73% <ø> (ø)
unittests-flytepropeller 42.61% <33.33%> (-0.02%) ⬇️
unittests-flytestdlib 57.57% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant