Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Docs] Add usage for jupyter notebook interactive mode #5997

Closed
wants to merge 20 commits into from

Conversation

Mecoli1219
Copy link

@Mecoli1219 Mecoli1219 commented Nov 12, 2024

Tracking issue

#5907

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Important Note: We should revert the change of import_project in conf.py after this PR (flytesnacks#1754) is merged!

Docs link

https://flyte--5997.org.readthedocs.build/en/5997/user_guide/flyte_fundamentals/running_and_scheduling_workflows.html

Signed-off-by: Mecoli1219 <[email protected]>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.03%. Comparing base (b3330ba) to head (2a420f7).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5997      +/-   ##
==========================================
- Coverage   37.03%   37.03%   -0.01%     
==========================================
  Files        1313     1313              
  Lines      131618   131622       +4     
==========================================
- Hits        48745    48743       -2     
- Misses      78645    78651       +6     
  Partials     4228     4228              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (-0.03%) ⬇️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.25% <ø> (ø)
unittests-flyteplugins 53.68% <ø> (+0.01%) ⬆️
unittests-flytepropeller 43.11% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
@Mecoli1219
Copy link
Author

@samhita-alla @davidmirror-ops How does this look? (I am using a hacky way now. I'm unsure if there is any other appropriate method to render a cell from Jupyter Notebook.)

image

@Mecoli1219 Mecoli1219 marked this pull request as ready for review November 16, 2024 08:54
@Future-Outlier
Copy link
Member

Michael, you are 絕活哥

@samhita-alla
Copy link
Contributor

@Mecoli1219 thanks so much for working on this! have you tried using https://docs.readthedocs.io/en/stable/guides/jupyter.html#using-notebooks-in-other-formats since myst-nb is already enabled as a sphinx extension?

@Mecoli1219
Copy link
Author

@samhita-alla I realize the link you provided renders the entire jupytext format file as a single sphinx page. What I'm specifically looking for is rendering just one cell from an ipynb file, ideally with a link to the flytesnacks example. (Previously this worked with rli/remoteliteralinclude, but since we've switched to literalinclude, we lost the linking capability).

Thinking about it now, I may be overcomplicating this. We could simply write similar example code directly in our docs like in my screenshot.

What are your thoughts on the interactive_mode documentation - should we include the complete example, or would it be better to just show the basic usage (like in my screenshot) and perhaps provide links to flytesnacks for more detailed examples?

@Mecoli1219 Mecoli1219 changed the title [WIP] [Docs] Add new page for jupyter notebook interactive mode [WIP] [Docs] Add usage for jupyter notebook interactive mode Nov 20, 2024
@davidmirror-ops
Copy link
Contributor

@Mecoli1219 I'd vote for rendering the notebook as a page if that's simpler. The benefit is that the notebook in flytesnacks would be "self contained" with code and instructions in a single place.

@Mecoli1219
Copy link
Author

Closed as the alternative PR is created: #6036

@Mecoli1219 Mecoli1219 closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants