Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Union type with dataclass ambiguous error and support superset comparison #5858

Merged
merged 30 commits into from
Nov 20, 2024

test: basemodel castable test, two level dataclass and ParentToChild …

7f28c35
Select commit
Loading
Failed to load commit list.
Merged

Fix Union type with dataclass ambiguous error and support superset comparison #5858

test: basemodel castable test, two level dataclass and ParentToChild …
7f28c35
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 20, 2024 in 0s

70.49% of diff hit (target 37.14%)

View this Pull Request on Codecov

70.49% of diff hit (target 37.14%)

Annotations

Check warning on line 39 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L38-L39 

Added lines #L38 - L39 were not covered by tests

Check warning on line 43 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L42-L43 

Added lines #L42 - L43 were not covered by tests

Check warning on line 68 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L66-L68 

Added lines #L66 - L68 were not covered by tests

Check warning on line 74 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L72-L74 

Added lines #L72 - L74 were not covered by tests

Check warning on line 81 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L79-L81 

Added lines #L79 - L81 were not covered by tests
View more details on Codecov