Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyteconsole url to FlyteWorkflow CRD #5449

Merged
merged 14 commits into from
Jun 14, 2024

Include review feedback

501d3ee
Select commit
Loading
Failed to load commit list.
Merged

Add flyteconsole url to FlyteWorkflow CRD #5449

Include review feedback
501d3ee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 13, 2024 in 0s

60.97% (-0.96%) compared to bd2f9a8

View this Pull Request on Codecov

60.97% (-0.96%) compared to bd2f9a8

Details

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (bd2f9a8) to head (501d3ee).
Report is 4 commits behind head on master.

Files Patch % Lines
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 69.23% 3 Missing and 1 partial ⚠️
flyteadmin/pkg/workflowengine/impl/k8s_executor.go 0.00% 1 Missing and 1 partial ⚠️
...peller/pkg/apis/flyteworkflow/v1alpha1/workflow.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5449      +/-   ##
==========================================
- Coverage   61.93%   60.97%   -0.96%     
==========================================
  Files         611      793     +182     
  Lines       36463    51352   +14889     
==========================================
+ Hits        22582    31313    +8731     
- Misses      11907    17152    +5245     
- Partials     1974     2887     +913

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov