Fix typos using codespell CI job #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5418 +/- ##
==========================================
- Coverage 61.10% 61.09% -0.01%
==========================================
Files 793 793
Lines 51156 51156
==========================================
- Hits 31257 31256 -1
- Misses 17027 17028 +1
Partials 2872 2872
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwdye
previously approved these changes
May 24, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
May 24, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Fix typos Signed-off-by: Eduardo Apolinario <[email protected]> * Fix unification of codespell file Signed-off-by: Eduardo Apolinario <[email protected]> * Alphabetize list of ignored words Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Fix typos Signed-off-by: Eduardo Apolinario <[email protected]> * Fix unification of codespell file Signed-off-by: Eduardo Apolinario <[email protected]> * Alphabetize list of ignored words Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Andrew Dye <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Typos made the project look unprofessional.
What changes were proposed in this pull request?
I removed the
.codespellrcfile to decrease confusion, since we configure codespell to run in a CI job.The
spellcheckmake target uses https://github.com/nektos/act to run that CI job locally.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link