Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing cache overwrite metadata update #4617

Merged
merged 9 commits into from
Dec 21, 2023

Merge branch 'master' into yushang/overwrite-cache/iteration

701bd4b
Select commit
Loading
Failed to load commit list.
Merged

Fixing cache overwrite metadata update #4617

Merge branch 'master' into yushang/overwrite-cache/iteration
701bd4b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 21, 2023 in 0s

59.02% (-0.01%) compared to 5d199a8

View this Pull Request on Codecov

59.02% (-0.01%) compared to 5d199a8

Details

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5d199a8) 59.03% compared to head (701bd4b) 59.02%.

Files Patch % Lines
datacatalog/pkg/manager/impl/artifact_manager.go 45.45% 5 Missing and 1 partial ⚠️
...acatalog/pkg/repositories/transformers/artifact.go 50.00% 2 Missing and 1 partial ⚠️
flytepropeller/pkg/controller/nodes/cache.go 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4617      +/-   ##
==========================================
- Coverage   59.03%   59.02%   -0.01%     
==========================================
  Files         622      622              
  Lines       52793    52816      +23     
==========================================
+ Hits        31164    31175      +11     
- Misses      19142    19150       +8     
- Partials     2487     2491       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov