Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterRole config for Ray #4405

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add ClusterRole config for Ray #4405

merged 4 commits into from
Nov 14, 2023

Conversation

davidmirror-ops
Copy link
Contributor

Tracking issue

Closes #4093

Docs link

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: davidmirror-ops <[email protected]>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72e7438) 59.81% compared to head (5f605c8) 60.27%.

❗ Current head 5f605c8 differs from pull request most recent head d627270. Consider uploading reports for the commit d627270 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4405      +/-   ##
==========================================
+ Coverage   59.81%   60.27%   +0.46%     
==========================================
  Files         632      562      -70     
  Lines       53644    40314   -13330     
==========================================
- Hits        32086    24300    -7786     
+ Misses      19033    13659    -5374     
+ Partials     2525     2355     -170     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 712ee8e into flyteorg:master Nov 14, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Ray plugin setup guide lacks ClusterRole step
3 participants