Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken unit tests #4265

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

squiishyy
Copy link
Contributor

Tracking issue

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: squiishyy <[email protected]>
Copy link
Contributor

@katrogan katrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this managed to pass checks when it was merged?

@squiishyy
Copy link
Contributor Author

i don't think the tests had a chance to run at the time, @pmahindrakar-oss had squashed and merged the PR and it didn't wait for the checks to finish. He made this issue: #4264

@squiishyy

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9af6d84) 59.83% compared to head (38afbc4) 59.64%.

❗ Current head 38afbc4 differs from pull request most recent head 1134e4d. Consider uploading reports for the commit 1134e4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4265      +/-   ##
==========================================
- Coverage   59.83%   59.64%   -0.19%     
==========================================
  Files         441      553     +112     
  Lines       36043    40068    +4025     
==========================================
+ Hits        21565    23899    +2334     
- Misses      12844    13819     +975     
- Partials     1634     2350     +716     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 576 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmahindrakar-oss pmahindrakar-oss merged commit e1c05db into flyteorg:master Oct 19, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants