Try 2: Add retry for oauth metadata endpoint

[squiishyy]

Tracking issue

squiishyy
Contributor
squiishyy commented 6 hours ago •
Tracking issue
https://unionai.atlassian.net/browse/CLOUD-175

Describe your changes

Added functionality to retry getting oauth metadata information upon 5xx error codes.
Added config values to be able to specify number of retry attempts and retry delay duration.
Added tests as well!

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Screenshots

Note to reviewers

[katrogan]

looks great!

[codecov]

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (60cf95e) 59.21% compared to head (fc547cd) 59.63%.
Report is 6 commits behind head on master.

❗ Current head fc547cd differs from pull request most recent head 59cc2ff. Consider uploading reports for the commit 59cc2ff to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
+ Coverage   59.21%   59.63%   +0.41%     
==========================================
  Files         621      553      -68     
  Lines       53106    40068   -13038     
==========================================
- Hits        31449    23893    -7556     
+ Misses      19148    13825    -5323     
+ Partials     2509     2350     -159     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
flyteadmin/auth/config/config.go	71.42% <ø> (ø)
flyteadmin/auth/config/config_flags.go	65.45% <100.00%> (+3.63%)	⬆️
flytepropeller/pkg/controller/nodes/resolve.go	88.05% <100.00%> (+0.71%)	⬆️
flytepropeller/pkg/controller/controller.go	11.52% <0.00%> (-0.23%)	⬇️
flytepropeller/pkg/compiler/validators/bindings.go	71.87% <76.92%> (+1.08%)	⬆️
...epropeller/pkg/controller/nodes/output_resolver.go	47.54% <60.00%> (+1.82%)	⬆️
flyteadmin/auth/authzserver/metadata_provider.go	76.47% <80.76%> (+5.23%)	⬆️
...tepropeller/pkg/compiler/errors/compiler_errors.go	65.81% <0.00%> (-2.58%)	⬇️
...opeller/pkg/controller/nodes/attr_path_resolver.go	76.84% <76.84%> (ø)

... and 551 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[katrogan]

looks good, just a few nits!

[welcome]

Congrats on merging your first pull request! 🎉