-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update Development Environment Setup Guide for MonoRepo #4257
[Docs] Update Development Environment Setup Guide for MonoRepo #4257
Conversation
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@pingsutw, can this PR be merged now? |
# Step 3.2: Generate code, fix lint errors and run unit tests for {flyteadmin}. | ||
# Note, flyteidl does not have unit tests, so you can skip the `make test_unit` command. | ||
# Note, flytestdlib only have `make generate` command. | ||
make generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Future-Outlier I think we still need to execute the following commands:
make generate
make lint
make test_unit
For instance, to generate the protobuf code, I guess we still need to run make generate
under flyteidl folder? Correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right, XD.
Doc link
https://flyte--4257.org.readthedocs.build/en/4257/community/contribute.html
Tracking issue
#4188
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers
@Yicheng-Lu-llll, @samhita-alla, @pingsutw please take a look, thanks a lot!