-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused setting in deployment charts #4252
fix: remove unused setting in deployment charts #4252
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. could you run make helm
and push it again
|
@pingsutw, @HeetVekariya
Not only just |
@HeetVekariya You should remember to sign off. |
Signed-off-by: HeetVekariya <[email protected]>
Signed-off-by: HeetVekariya <[email protected]>
37311f9
to
be4217a
Compare
|
|
@HeetVekariya Yes, you can join the Slack Channel, and feel free to direct message me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hey @pingsutw, can we merge this PR? Does this look good to you? |
Congrats on merging your first pull request! 🎉 |
Thank you for merging 👍 |
Tracking issue
Closes #4251
Describe your changes
Changes made: Removed above code
Files changed:
Total changes: 4
Check all the applicable boxes
Screenshots
Note to reviewers