Cancel a currently running workflow from the same PR when a new workflow is triggered #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low is triggered Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4200 +/- ##
==========================================
+ Coverage 59.00% 60.18% +1.17%
==========================================
Files 619 570 -49
Lines 52827 41216 -11611
==========================================
- Hits 31170 24804 -6366
+ Misses 19173 14006 -5167
+ Partials 2484 2406 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pingsutw
requested review from
eapolinario,
jeevb and
EngHabu
and removed request for
eapolinario and
jeevb
|
This is a great feature! |
eapolinario
reviewed
Oct 19, 2023
.github/workflows/checks.yml
Outdated
| @@ -1,5 +1,9 @@ | |||
| name: Components Checks | |||
|
|
|||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | |||
There was a problem hiding this comment.
We need the || github.ref to handle the non-PR case.
Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
as title, always run the latest workflow in the PR.
https://stackoverflow.com/a/72408109/9574775
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA