Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bump git tags workflow #4074

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Add bump git tags workflow #4074

merged 5 commits into from
Sep 26, 2023

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Sep 26, 2023

Describe your changes

This PR adds a github workflow to bump the patch version of all necessary git tags (as described in https://go.dev/ref/mod#vcs-version). This is necessary so that downstream golang repositories can update to specific versions of components.

In terms of the mechanics of the gh workflow, on merges to master we bump the patch version of the latest tag and we use that version create tags for each component. For example, let's say that the we're updating to version v1.9.1, this is going to create 7 tags:

  • v1.9.1
  • datacatalog/v1.9.1
  • flyteadmin/v1.9.1
  • flytecopilot/v1.9.1
  • flyteplugins/v1.9.1
  • flytepropeller/v1.9.1
  • flytestdlib/v1.9.1

I also took the chance to improve the fork-ability of the flyte repo. I also tested these changes on a fork.

A subsequent change is going to modify the release scripts.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (73d98d1) 58.97% compared to head (5b168f9) 57.44%.
Report is 35 commits behind head on master.

❗ Current head 5b168f9 differs from pull request most recent head 932e97d. Consider uploading reports for the commit 932e97d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4074      +/-   ##
==========================================
- Coverage   58.97%   57.44%   -1.53%     
==========================================
  Files         584      393     -191     
  Lines       50434    28877   -21557     
==========================================
- Hits        29741    16588   -13153     
+ Misses      18319    10605    -7714     
+ Partials     2374     1684     -690     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/auth/cookie.go 81.60% <100.00%> (+2.76%) ⬆️
flyteadmin/auth/cookie_manager.go 72.64% <100.00%> (+11.04%) ⬆️
flyteadmin/plugins/registry.go 100.00% <ø> (ø)
...opeller/pkg/controller/nodes/task/plugin_config.go 94.59% <100.00%> (+1.41%) ⬆️
flyteadmin/pkg/manager/impl/util/resources.go 91.52% <0.00%> (+0.85%) ⬆️
flytepropeller/pkg/controller/controller.go 11.56% <0.00%> (-0.16%) ⬇️
flytepropeller/pkg/controller/nodes/executor.go 61.18% <0.00%> (+0.62%) ⬆️
...g/controller/nodes/subworkflow/launchplan/admin.go 69.61% <75.00%> (+2.17%) ⬆️
flyteadmin/auth/handlers.go 40.15% <83.33%> (+3.81%) ⬆️
flytepropeller/pkg/controller/nodes/array/utils.go 83.87% <66.66%> (+2.33%) ⬆️

... and 567 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Sep 26, 2023
@eapolinario eapolinario merged commit 8090b16 into master Sep 26, 2023
34 checks passed
@eapolinario eapolinario deleted the monorepo--tag-components branch September 26, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants