Skip to content

Commit

Permalink
fix: change test name and fix err
Browse files Browse the repository at this point in the history
Signed-off-by: mao3267 <[email protected]>
  • Loading branch information
mao3267 committed Nov 19, 2024
1 parent 81445a7 commit 9b19f04
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions flytepropeller/pkg/compiler/validators/typing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ func TestMapCasting(t *testing.T) {
assert.True(t, castable, "castable from Struct to struct")
})

t.Run("dataclass cast to same dataclass with draft 2020-12 (one level)", func(t *testing.T) {
t.Run("SameDataclassOneLevel(draft 2020-12)", func(t *testing.T) {
/*
@dataclass
class A:
Expand Down Expand Up @@ -657,7 +657,7 @@ func TestMapCasting(t *testing.T) {
assert.True(t, castable, "dataclass castable with one level properties")
})

t.Run("dataclass cast to dataclass with draft 2020-12 (two level)", func(t *testing.T) {
t.Run("SameDataclassTwoLevel(draft 2020-12)", func(t *testing.T) {
/*
@dataclass
class A:
Expand Down Expand Up @@ -825,7 +825,7 @@ func TestMapCasting(t *testing.T) {
assert.True(t, castable, "dataclass castable with two level properties")
})

t.Run("dataclass cast to superset dataclass with draft 2020-12 (one level)", func(t *testing.T) {
t.Run("BigToSmallAndChildToParent(dataclass draft 2020-12)", func(t *testing.T) {
/*
@dataclass
class A:
Expand All @@ -845,7 +845,10 @@ func TestMapCasting(t *testing.T) {
"required": &structpb.Value{
Kind: &structpb.Value_ListValue{
ListValue: &structpb.ListValue{
Values: []*structpb.Value{{Kind: &structpb.Value_StringValue{StringValue: "a"}}},
Values: []*structpb.Value{
{Kind: &structpb.Value_StringValue{StringValue: "a"}},
{Kind: &structpb.Value_StringValue{StringValue: "b"}},
},
},
},
},
Expand Down

0 comments on commit 9b19f04

Please sign in to comment.