This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
refactoring profile handler into entrypoints #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luded in single binary Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 68.50% 69.67% +1.16%
==========================================
Files 31 31
Lines 1667 1385 -282
==========================================
- Hits 1142 965 -177
+ Misses 447 342 -105
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. |
pingsutw
approved these changes
Aug 23, 2023
eapolinario
approved these changes
Aug 23, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* moved profutils profiling server start to entrypoint so it is not included in single binary Signed-off-by: Daniel Rammer <[email protected]> * fixed imports Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently the single binary is using this profile handler to serve. This should be explicitly started in the single binary, which also allows us to add a handler for k8s metrics.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#2975
Follow-up issue
NA