Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari Clicking problem #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Safari Clicking problem #8

wants to merge 1 commit into from

Conversation

adminy
Copy link

@adminy adminy commented Mar 22, 2019

Added mouse click event listener, so safari users are happy.

Also perhaps close issue #7 .

Added mouse click event listener, so safari users are happy.
@luney112
Copy link
Contributor

I would personally suggest adding https://github.com/jquery/PEP instead of the custom mouse events (which may even fire off events effectively twice on all other browsers).

@adminy
Copy link
Author

adminy commented Mar 22, 2019

It already looks full of dependencies in my opinion, took me hours to figure out how to completely remove typescript, so I can port it to non-browser, non-node environment. I would suggest make it more independent among modules before adding anything else.

@luney112
Copy link
Contributor

Why would you remove typescript? I don't quite understand. Typescript will transpile the code to es6/es5 as necessary. Typescript is not what runs in the browser.

PEP itself should run in all environments that have the proper host objects and can run javascript. What environment do you need to run in?

@adminy
Copy link
Author

adminy commented Mar 29, 2019

A headless VM running a stripped down V8 javascript engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants