Fix 'macroexpand' output in Chapter 8 #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of calling `macroexpand` for the `if-valid` macro is shown at the end of Chapter 8. However, the output is presented as code to be input by the user rather than code that will be output (by listing it as a comment). This fixes that. It is noted for completeness that in Clojure 1.10.0, the code as written will fail to compile. This is because the spec for `macroexpand` no longer allows simple symbols (such as, in this case, `my-error-name`). These need to be appended with a `#`. However, since the current edition is written for Clojure 1.9.0, fixing this would represent a more comprehensive change that is beyond the scope of this PR.
pyrmont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of calling
macroexpandfor theif-validmacro is shown at the end of Chapter 8. However, the output is presented as code to be input by the user rather than code that will be output (by listing it as a comment). This fixes that.It is noted for completeness that in Clojure 1.10.0, the code as written will fail to compile. This is because the spec for
macroexpandno longer allows simple symbols (such as, in this case,my-error-name). These need to be appended with a#. However, since the current edition is written for Clojure 1.9.0, fixing this would represent a more comprehensive change that is beyond the scope of this PR.