Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe stdout/stderr of utils.RunCommand to machine logs #228

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

benwaffle
Copy link
Contributor

This will allow us to immediately see any errors if any commands fail

This will allow us to immediately see any errors if any commands fail
@benwaffle benwaffle requested review from davissp14 and ndarilek June 19, 2024 20:51
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just one quick note.

internal/utils/shell.go Outdated Show resolved Hide resolved
@benwaffle benwaffle requested a review from davissp14 June 19, 2024 22:09
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benwaffle benwaffle merged commit 6b1cc60 into master Jun 19, 2024
6 checks passed
@benwaffle benwaffle deleted the log-errors branch June 19, 2024 22:41
davissp14 pushed a commit that referenced this pull request Jun 25, 2024
* Pipe stdout/stderr of utils.RunCommand to machine logs

This will allow us to immediately see any errors if any commands fail

* use log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants