Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty #2

Open
wants to merge 100 commits into
base: develop
Choose a base branch
from
Open

Pretty #2

wants to merge 100 commits into from

Conversation

wkleinheerenbrink
Copy link

No description provided.

jgadelange and others added 30 commits March 1, 2014 11:38
@jgadelange
Initial setup for html template and js
263dbb6
@wkleinheerenbrink
Rewrote inline JS to new baseInlineFormset jQuery plugin
a49736a
@wkleinheerenbrink
Remove unused templatedir
92f7b3c
@wkleinheerenbrink
Do not add form on unRemoveForm if max forms would be exceeded
9605a03
@wkleinheerenbrink
Implemented customizable labels
f5b1271
@wkleinheerenbrink
Add alternative inline styles
d65491c
@wkleinheerenbrink
Insert new form before the emptyForm
130f8f2
@wkleinheerenbrink
Start using custom stylesheet for inline
2a3d93d
@wkleinheerenbrink
Alternate row coloring
8542585
@wkleinheerenbrink
Style add button
b053ef9
@wkleinheerenbrink
Style delete button
502e66a
@wkleinheerenbrink
Style removed row
c65ca13
@wkleinheerenbrink
Fix toggle 'disabled' class for add button
3ba2108
@wkleinheerenbrink
Styled disabled add button
895c483
@wkleinheerenbrink
Fix delete text
1075682
@wkleinheerenbrink
Improved stacked html to show delete buttons for every item
31d348b
@wkleinheerenbrink
Style removed class for stacked
0165025
@wkleinheerenbrink
Change 'unremove' label into 'undo remove'
5581ed6
@wkleinheerenbrink
Make maximum number of objects message translatable
b1d6f0e
@wkleinheerenbrink
Cleanup
c7872c9
@wkleinheerenbrink
Define base template
e6ae578
@wkleinheerenbrink
Add changeForm methods to baseinline
da692b4
@wkleinheerenbrink
Implement edit form
ef8857a
@wkleinheerenbrink
Show edit form on add
3139ba4
@wkleinheerenbrink
Fix change button on newly added forms
53e3cc6
@wkleinheerenbrink
Implement formatter for item label
c1a7f83
@wkleinheerenbrink
Add required missing hidden fields
c528000
@wkleinheerenbrink
Show invalid signs
1c50537
@wkleinheerenbrink
Change methodname 'changeForm' into 'showChangeForm' for clarity
0f72922
@wkleinheerenbrink
Hard remove form on delete if it has no changes yet
8e9c89f
@wkleinheerenbrink
Append buttonRow to fieldset
6879307
@wkleinheerenbrink
Add style to inline tabular edit
6312bc6
@wkleinheerenbrink
Use 'OK' instead of save
3aa3e52
@wkleinheerenbrink
Disable/enable change and delete on edit
461414b
@wkleinheerenbrink
Hide original, do not add 'hidden' class anymore
a7ea9e2
@wkleinheerenbrink
Render only a substring of 30 in table
12cf28a
@wkleinheerenbrink
Undo remove if user presses change
2ccaf1c
@wkleinheerenbrink
Fix handleOpenEditor
ad5ab91
@wkleinheerenbrink
Fix managementform for saving
d52c695
@wkleinheerenbrink
Remove unnecessary height definitions
3e991e6
@wkleinheerenbrink
Fix animation settings for activating editor
f16a18a
@wkleinheerenbrink
enable to save the whole item when an inline is still open
434f361
@wkleinheerenbrink
Add a second inline to test if library works with multiple inlines
052597d
@wkleinheerenbrink
Save the whole form (nonetheless open editors) on submit
32c6ad4
@wkleinheerenbrink
When saving inline form, error class is removed
6b5b4bb
@wkleinheerenbrink
Fix delete buttons for stacked and tabular
9aacb95
@wkleinheerenbrink
Add border around active fieldset
c12c870
@wkleinheerenbrink
Merge pull request #1 from fluxility/intable-editor
8a87895 
Converted current pretty inline into an 'intable editor' instead of an external editor
@wkleinheerenbrink
Add Django < 1.6 support by adding newer version of jQuery
c16cd0e
@wkleinheerenbrink
Fix jQuery check
0ba377d
@wkleinheerenbrink
Fix compatibility for django < 1.6 by check has_auto_field and needs_…
c7611d4 
…explicit_pk_field
@wkleinheerenbrink
Use consistent name 'inline-item' in each inline layout
4c03046
@wkleinheerenbrink
Apply fix from c7611d4 also to Tabular and Stacked
bc3fd31
jgadelange
jgadelange reviewed Mar 15, 2014
View reviewed changes
pretty_inline/static/pretty_inline/js/baseInlineFormset.js
this.element = element;
this.$element = $(this.element);
this.settings = $.extend({}, defaults, options);
// this._defaults = defaults;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented lines of code 😢

@jgadelange
Copy link
Member

Looking at the code I only found two things:

  • Commented lines of code
  • I still think the default value for extra in all (pretty) inlines should be 0.

Will now look at usage. More soon!

@jgadelange
Copy link
Member

Pretty:

  • "Add another book" when no books are there is strange.
  • The column for editing and deleting objects is to wide, which makes the data in the table less visible.
  • When submitting errors on a page by default an extra item appears. Even when this means you have more than allowed. In this case also the add button looks active but doesn't do anything.
  • On adding the last allowed object I get a message I am at the max. This also happens when having the maximum number of objects and opening an editor.
  • When marking an object for deletion and then submit the page with errors the deletion disappears.

Stacked & Tabular:

  • Can't find whether it is desired behaviour the empty forms don't disappear when deleting them. I think this is better.
  • The last 3 remarks for pretty also hold for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkleinheerenbrink @jgadelange