Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header not sticking in reverse direction #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JAicewizard
Copy link

@JAicewizard JAicewizard commented Jan 26, 2023

localToGlobal Is not up to date during the layout phase. This PR moves that code to the paint phase. This is not ideal, but the operations performed are not expensive so it shouldn't be a performance problem. In fact this would increase the performance as it would not need to layout for a scroll update.

fixes #67

Copy link

@DeD1rk DeD1rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Jumpy header inside CustomScrollView with center key
3 participants