Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the const in StatefulShellRouteData generation #8502

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

hannah-hyj
Copy link
Member

fixes:flutter/flutter#161305
also fix some typos: statefull* -> stateful*

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2025
@auto-submit auto-submit bot merged commit 040f805 into flutter:main Jan 28, 2025
77 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 28, 2025
flutter/packages@258f6dc...02c6fef

2025-01-28 [email protected] Revert "[shared_preferences] Add
shared preferences devtool" (flutter/packages#8515)
2025-01-28 [email protected]
[webview_flutter_wkwebview] Updates the internal wrapper to use
`@ProxyApi` from pigeon (flutter/packages#8311)
2025-01-28 [email protected] update the `const` in
StatefulShellRouteData generation (flutter/packages#8502)
2025-01-27 [email protected]
[video_player_platform_interface] Platform view support
(flutter/packages#8453)
2025-01-27 [email protected] [multicast_dns] Rewrite `_readFQDN` to
avoid recursion (flutter/packages#8390)
2025-01-27 [email protected] [shared_preferences] Fix Android type
mismatch regression (flutter/packages#8512)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants