Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints #8345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 24, 2024

A few dependency bumps are failing due to the all_packages test targeting a lower version of Android SDK than the example apps. Instead of hardcoding an SDK version which needs to be updated manually (https://github.com/flutter/packages/pull/7891/files#r1815169527), instead use flutter.compileSdkVersion, similar to #3847.

Unblocks attempts to increase dependencies versions that require SDK 35 or higher
#7985

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Copy link
Member Author

jmagman commented Dec 26, 2024

 │ [!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher.                    

@jmagman
Copy link
Member Author

jmagman commented Dec 26, 2024

distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip

Bump like #6742

@stuartmorgan stuartmorgan added the triage-android Should be looked at in Android triage label Jan 14, 2025
@jmagman
Copy link
Member Author

jmagman commented Jan 15, 2025

Error now is that the legacy variant is using a lower version of AGP and needs 8.1

[!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher. │
│ Please upgrade to a newer AGP version. The version of AGP that your project uses is likely │
│ defined in: │
│ /b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle, │
│ in the 'plugins' closure (by the number following "com.android.application"). │
│ Alternatively, if your project was created with an older version of the templates, it is likely │
│ in the buildscript.dependencies closure of the top-level build.gradle: │
│ /b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle, │
│ as the number following "com.android.tools.build:gradle:".

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8727714051273194977/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-android Should be looked at in Android triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants