Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip the wasm benchmark #8320

Merged
merged 19 commits into from
Oct 9, 2024
Merged

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Sep 11, 2024

Depends on flutter/packages#7743 landing and web_benchmarks 3.0.0 being published.

Part of general wasm effort: #7856

@kenzieschmoll
Copy link
Member Author

kenzieschmoll commented Sep 30, 2024

EDIT: this was due to an outdated Chrome version. Updating chrome fixed the issue.
The js benchmark works here but the wasm benchmark does not:

04:13 +0 -1: Can run web benchmarks with WASM [E]                                                                
  Caught browser-side error: Exception: `startMeasureFrame` called twice in a row.
      at module0.Error._throwWithCurrentStackTrace (http://localhost:9999/main.dart.wasm:wasm-function[1082]:0x1ab4f6)
      at module0._RecordingWidgetsBinding.handleDrawFrame (http://localhost:9999/main.dart.wasm:wasm-function[33522]:0x4b8c7b)
      at module0.__RecordingWidgetsBinding&BindingBase&GestureBinding&SchedulerBinding._handleDrawFrame (http://localhost:9999/main.dart.wasm:wasm-function[7247]:0x2495ac)
      at module0.__RecordingWidgetsBinding&BindingBase&GestureBinding&SchedulerBinding._handleDrawFrame tear-off trampoline (http://localhost:9999/main.dart.wasm:wasm-function[7249]:0x2495cc)
      at module0.invoke (http://localhost:9999/main.dart.wasm:wasm-function[4474]:0x208c6b)
      at module0.initializeEngineServices closure at org-dartlang-sdk:///lib/_engine/engine/initialization.dart:154:39 (http://localhost:9999/main.dart.wasm:wasm-function[34140]:0x4c93f3)
      at module0.closure wrapper at org-dartlang-sdk:///lib/_engine/engine/initialization.dart:154:39 trampoline (http://localhost:9999/main.dart.wasm:wasm-function[34147]:0x4c9715)
      at module0._1759 (http://localhost:9999/main.dart.wasm:wasm-function[1032]:0x1a9efb)
  dart:async                                     _Completer.completeError
  package:web_benchmarks/src/runner.dart 254:25  BenchmarkServer.run.<fn>
  ===== asynchronous gap ===========================
  dart:async                                     _CustomZone.registerUnaryCallback
  package:web_benchmarks/src/runner.dart 248:27  BenchmarkServer.run.<fn>
  package:shelf/src/cascade.dart 77:53           Cascade.handler.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async                                     Future.then
  package:shelf/src/cascade.dart 76:58           Cascade.handler.<fn>
  package:shelf/src/cascade.dart 76:47           Cascade.handler.<fn>.<fn>
  dart:async                                     new Future.sync
  package:shelf/src/cascade.dart 76:21           Cascade.handler.<fn>
  package:shelf/shelf_io.dart 140:29             handleRequest
  package:shelf/shelf_io.dart 93:9               serveRequests.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:_http                                     _HttpServer.listen
  package:shelf/shelf_io.dart 92:14              serveRequests.<fn>
  package:shelf/src/util.dart 21:20              catchTopLevelErrors
  package:shelf/shelf_io.dart 91:3               serveRequests
  package:web_benchmarks/src/runner.dart 316:16  BenchmarkServer.run
  ===== asynchronous gap ===========================
  dart:async                                     _CustomZone.registerUnaryCallback
  package:web_benchmarks/src/runner.dart 135:42  BenchmarkServer.run
  package:web_benchmarks/server.dart 75:5        serveWebBenchmark
  benchmark/devtools_benchmarks_test.dart 61:28  _runBenchmarks
  benchmark/devtools_benchmarks_test.dart 50:15  main.<fn>

@eyebrowsoffire any ideas? This stack trace is with a path dependency on web_benchmarks with the flutter/packages#7743 changes applied.

@kenzieschmoll kenzieschmoll marked this pull request as ready for review September 30, 2024 23:27
@kenzieschmoll kenzieschmoll requested a review from a team as a code owner September 30, 2024 23:27
@kenzieschmoll kenzieschmoll requested review from elliette and removed request for a team September 30, 2024 23:27
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 30, 2024
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632
@kenzieschmoll
Copy link
Member Author

This benchmark tests is failing because the Chrome version on the ubuntu-latest image is behind the current Chrome stable. The benchmarks pass locally: actions/runner-images#10726

@kenzieschmoll kenzieschmoll merged commit 06a27e1 into flutter:master Oct 9, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the unskip-wasm branch October 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants