-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip the wasm benchmark #8320
Conversation
EDIT: this was due to an outdated Chrome version. Updating chrome fixed the issue.
@eyebrowsoffire any ideas? This stack trace is with a path dependency on web_benchmarks with the flutter/packages#7743 changes applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632
This benchmark tests is failing because the Chrome version on the ubuntu-latest image is behind the current Chrome stable. The benchmarks pass locally: actions/runner-images#10726 |
Depends on flutter/packages#7743 landing and
web_benchmarks
3.0.0 being published.Part of general wasm effort: #7856